search

sakaicontrib / attendance

A simple Sakai tool for tracking attendance that integrates with the Gradebook.
Educational Community License v2.0
12 stars 20 forks source link

Dark theme issues #94

Open msoupcoff opened 2 years ago

msoupcoff commented 2 years ago

Certain colors look to be hardcoded and thus look out of place or fail color contrast test when switching to dark theme. Also reported in core jira project (https://sakaiproject.atlassian.net/browse/SAK-46981)

  1. On Attendance tab: AttendanceTab

  2. After selecting an item to take attendance: TakeAttendance

  3. After selecting an item to take attendance & selecting the Edit attendance item icon: TakeAttendanceEditItem

  4. After selecting an item to take attendance & selecting the Print icon: TakeAttendancePrint

  5. After selecting an item to take attendance & scroll over students (odd rows): TakeAttendanceRowScrollover

  6. After selecting an item to take attendance & selecting a student's name AttendanceSelectedStudent

  7. On Attendance By Student tab: AttendanceByStudent

  8. On Grading tab: AttendanceGrading

  9. On Settings tab: AttendanceSettings

profmikegreene commented 2 years ago

You can assign this to me if no one on your team isn't already working on it.

davidpbauer commented 2 years ago

We have made some fixes to the dark theme locally. I can see if Joe who made the changes can make a pull request. It would at least be a place to start if you have more pressing things.