search

sakaki- / sakaki-tools

Overlay containing various utility ebuilds for Gentoo on EFI.
79 stars 53 forks source link

efitools-1.9.2::sakaki-tools fails to build, while ::gentoo works #18

Open andrey-utkin opened 4 years ago

andrey-utkin commented 4 years ago

Hi, Looks like main tree's ebuild is well maintained, so perhaps could be dropped from this overlay?

cc -I/var/tmp/portage/app-crypt/efitools-1.9.2/work/efitools-1.9.2/include/ -I/usr/include/efi -I/usr/include/efi/x86_64 -I/usr/include/efi/protocol -O2 -pipe -march=skylake
 -fpic -Wall -fshort-wchar -fno-strict-aliasing -fno-merge-constants -fno-stack-protector -ffreestanding -fno-stack-check -DGNU_EFI_USE_MS_ABI -DEFI_FUNCTION_WRAPPER -mno-red
-zone  -fpic -Wall -fshort-wchar -fno-strict-aliasing -fno-merge-constants -fno-stack-protector -ffreestanding -fno-stack-check -DGNU_EFI_USE_MS_ABI -DEFI_FUNCTION_WRAPPER -m
no-red-zone -DCONFIG_x86_64 -fno-toplevel-reorder -DBUILD_EFI -c execute.c -o execute.efi.o
console.c:360:5: error: ‘EFI_WARN_UNKNOWN_GLYPH’ undeclared here (not in a function); did you mean ‘EFI_WARN_UNKOWN_GLYPH’?
  360 |  {  EFI_WARN_UNKNOWN_GLYPH,     L"Warning Unknown Glyph"},
      |     ^~~~~~~~~~~~~~~~~~~~~~
      |     EFI_WARN_UNKOWN_GLYPH
make[1]: *** [../Make.rules:105: console.efi.o] Error 1
sakaki- commented 4 years ago

Which version of sys-boot/gnu-efi are you using? Recently (true for at least 3.0.11) EFI_WARN_UNKOWN_GLYPH was dropped and EFI_WARN_UNKNOWN_GLYPH used instead, causing an issue with the main-tree ebuild of efitools, that is patched here in the overlay.

https://forums.gentoo.org/viewtopic-p-8393064.html#8393064

Guess a cleaner patch would ensure check which variant was defined, and build accordingly.

sakaki- commented 4 years ago

31 Oct 2020: sadly, due to legal obligations arising from a recent change in my 'real world' job, I must announce I am standing down as maintainer of this project with immediate effect. For the meantime, I will leave the repo up (for historical interest, and since the ebuilds etc. may be of use to others); however, I plan no further updates, nor will I be accepting / actioning further pull requests or bug reports from this point. Email requests for support will also have to be politely declined, so, please treat this as an effective EOL notice.

For further details, please see my post here.

If you have used my EFI Guide (and this repo) to install your PC-based Gentoo system, it should still continue to work for some time, but you should now take steps to migrate to a baseline Gentoo Handbook install (since the underlying tools, such as buildkernel, will also now no longer be supported and may eventually fail as more modern kernels etc. are released).

With sincere apologies, sakaki ><