search

sakaki- / sakaki-tools

Overlay containing various utility ebuilds for Gentoo on EFI.
79 stars 53 forks source link

sys-kernel/genkernel-next: Fix busybox location #28

Closed TheGreatMcPain closed 4 years ago

TheGreatMcPain commented 4 years ago

The patch that updates busybox uses the old DISTDIR default, which is /usr/portage/distfiles, and requires the user to modify genkernel.conf so that it matches the current default DISTDIR, which is /var/cache/distfiles.

To get around needing to manually modify genkernel.conf I've modified the ebuild so that it will automatically change the location of busybox's source tarball in genkernel.conf to whatever DISTDIR is set to.

sakaki- commented 4 years ago

Thanks - my test machine has symlinks for the old locations so I missed this issue ><

PS: I guess $(portageq distdir) would also work to get the canonical directory, but your approach works fine too. Merging now.

TheGreatMcPain commented 4 years ago

I never thought about doing $(portageq distdir). Can I make a new pull-request since I think using portageq would be much more cleaner?

TheGreatMcPain commented 4 years ago

I tested $(portageq distdir), and ran into the same issue I had when I tried echo $DISTDIR. They both return\ /var/tmp/portage/sys-kernel/genkernel-next-70-r1/distdir.