search

sakaki- / sakaki-tools

Overlay containing various utility ebuilds for Gentoo on EFI.
78 stars 53 forks source link

Make buildkernel work with Gentoo's virtual/linux-sources package. #6

Closed spijet closed 7 years ago

spijet commented 7 years ago

This way it won't depend on some specific kernel sources, so alternative kernel users won't have to keep 2 sets of kernel sources around.

sakaki- commented 7 years ago

Looks good. My only comment would be that for tweaked ebuilds like this, it is often better to have a vanilla copy (or mv) as the first commit, then a second commit with the actual changes (and then any other commits you found necessary, such as e.g. the tab change as above). Makes it easier to review without having to leave GitHub to do a diff. The changes can always be squashed when pulled.

If you would like to resubmit in that format, I will merge and test. Thanks!

spijet commented 7 years ago

Oh, ok, will do that now.