sakana3 / PolyQuilt

Blender Lowpoly support addon for Blender2.8
https://sakana3.github.io/PolyQuilt/
530 stars 38 forks source link

Knife Tool Broken #50

Open DNollChimera opened 2 years ago

DNollChimera commented 2 years ago

Knife Tool seems to be broken. I only get Error messages when i want to use it

AVA3d commented 2 years ago

Confirming, it is broken in Blender 3.1

Error: Python: Traceback (most recent call last): File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\pq_operator.py", line 172, in modal raise e File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\pq_operator.py", line 168, in modal val = self.update( context, event) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\pq_operator.py", line 205, in update ret = self.currentSubTool.Update(context, event) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\subtools\subtool.py", line 97, in Update ret = subTool.Update(context , event) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\subtools\subtool.py", line 116, in Update ret = self.OnUpdate(context,event) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\subtools\subtool_makepoly.py", line 252, in OnUpdate self.LMBEvent.Update( context , event ) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\utils\mouse_event_util.py", line 110, in Update self.OnEvent( event , MBEventType.Release ) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\utils\mouse_event_util.py", line 142, in OnEvent self.eventFunc( self.eventClass , self) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\subtools\subtool_makepoly.py", line 218, in LMBEventCallback self.isEnd = self.AddVert(self.currentTarget ) == False File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\subtools\subtool_makepoly.py", line 369, in AddVert self.bmo.face_split( face , self.vert_array.get(-2) , self.vert_array.get(-1) ) File "C:\Users\ \AppData\Roaming\Blender Foundation\Blender\3.1\scripts\addons\PolyQuilt\QMesh\QMeshOperators.py", line 386, in face_split return bmesh.utils.face_split( face , v0 , v1 , coords , use_exist ) TypeError: face_split() takes at most 3 positional arguments (5 given)

haystax78 commented 2 years ago

Probably not a real fix, but this worked for me: In QMeshOperators.py change line 386 from return bmesh.utils.face_split( face , v0 , v1 , coords , use_exist ) to return bmesh.utils.face_split( face , v0 , v1 )

This made cutting functional again for me with no errors. I never used this tool until recently so I can't compare it to it's intended behavior, but it seems to be working as I'd expect.

Smulb commented 1 year ago

Tried suggested change to QMeshOperator.py line 386 but it didn't work for me. Maybe you changed also something else maybe. Just hoping to find a solution for this Knife functionality problem.