Closed ehehhh closed 6 years ago
Sorry for replying so late @ehehhh. I was travelling for the past week. So I cannot think of situations where long-pressing on links will add any value over single-tapping them. Can you please help me understand this?
Hello @Saketme! I am currently building a messenger into our app and when a message contains a link, a user can choose to single-tap to open the link like normal, but also long press to open a small popup menu with the option to copy the link to clipboard. It's definitely not a very important feature, but a nice add-on to the library.
Makes sense. I've seen Whatsapp and Telegram do this. But before we merge this to the library, can you please remove the GestureDetector? BetterLinkMovementMethod.java
already has an onTouchEvent()
where you can schedule a delayed handler and listen to long presses. This is also how Views listen to long presses. Your way looks kinda hacky :)
Also, sorry again for the late reply. I was occupied with Droidcon, which happened yesterday here in India.
Update: I guess you've gotten busy. I'll try adding this support myself.
Hey, yeah, sorry, I've been quite busy, haven't got around to doing this. Would be great if you could add it :)
@Saketme Same problem here. I want to implement copy on long press.
Sorry for not paying any attention to this. I will begin working on this tomorrow.
@Saketme Thanks :)
@ehehhh I see you have made more useful changes to the library in your fork. Can you please open a PR for them, except for the last long-press support commit?
Update: Or nevermind, I ended up adding those changes for enabling long-click support :)
This will be a part of v2.
Update: v2 released!
@debjitk @ehehhh.
I feel like this library is missing an important feature - long press handling on the links.