search

saket / Dank

Here lies the greatest Reddit app that was never released
https://saket.me/dank
Apache License 2.0
814 stars 133 forks source link

fix: check if package name is enabled #17

Closed SubhrajyotiSen closed 5 years ago

SubhrajyotiSen commented 5 years ago

Checking only if the app is installed is not sufficient. Sometimes it can be disabled. In such a case, Intent won't be fired successfully.

Steps to reproduce:

  1. Diable Youtube app
  2. Go to /r/videos and try opening any of the videos.

Expected: Video opens in YouTube

Actual: Error toast

This fix opens the URL as a regular URL if app is disabled

SubhrajyotiSen commented 5 years ago

This will be used in the fix for #16

saket commented 5 years ago

Thank you folks @SubhrajyotiSen @Tunous! There's a typo in your commit message. Could you please fix that?

SubhrajyotiSen commented 5 years ago

Done