search

saket / Dank

Here lies the greatest Reddit app that was never released
https://saket.me/dank
Apache License 2.0
814 stars 133 forks source link

Giphy API Key #2

Closed SubhrajyotiSen closed 5 years ago

SubhrajyotiSen commented 5 years ago

Is it fine to have the API key public? https://github.com/saket/Dank/blob/master/app/src/main/java/me/saket/dank/di/DankApi.java#L31

saket commented 5 years ago

I considered removing the API keys. I'm using free accounts for both Imgur and Giphy so I don't really care if it gets shared. I won't be charged for them anyway. Do you see any other issues?

SubhrajyotiSen commented 5 years ago

In that case, no issues.

saket commented 5 years ago

Thanks for asking btw!