search

saket / cascade

Nested popup menus with smooth height animations for Android
https://saket.github.io/cascade
Apache License 2.0
2.02k stars 67 forks source link

Setting visibility to false shows an empty item #12

Closed waseefakhtar closed 3 years ago

waseefakhtar commented 3 years ago

Setting visibility to false currently functions like View.INVISIBLE and not View.GONE.

Demo

saket commented 3 years ago

Interesting. Filtering out invisible items in the list should be easy and should only require an if condition here: https://github.com/saket/cascade/blob/891031ab4d52dc00f41fdb0fb1e094279e92143c/cascade/src/main/java/me/saket/cascade/CascadeMenuAdapter.kt#L38

Wanna send a PR?

waseefakhtar commented 3 years ago

Sure :)