search

saket / cascade

Nested popup menus with smooth height animations for Android
https://saket.github.io/cascade
Apache License 2.0
2.02k stars 67 forks source link

Opens submenu multiple times if you click a child multiple times #41

Closed MV-GH closed 11 months ago

MV-GH commented 1 year ago

I am double clicking on that DropdownMenuItem which opens that submenu twice vmOM9iOO5C

MV-GH commented 11 months ago

This is not fixed, I can still reproduce this with 2.3.0

MV-GH commented 11 months ago

Because I assume

  internal fun navigateTo(entry: CascadeBackStackEntry) {
    if (entry != backStack.lastOrNull()) {
      backStack.add(entry)
    }
  }

Each time I click, it creates another class thus the comparison fails, as its unique each time

saket commented 10 months ago

Serves me right for not adding an automated test for this 🙂. Let me fix this (again).