search

saket / cascade

Nested popup menus with smooth height animations for Android
https://saket.github.io/cascade
Apache License 2.0
2.02k stars 67 forks source link

Shadow elevation should not be limited if a project's minSdk is 31 or above #43

Closed saket closed 11 months ago

saket commented 11 months ago

cascade copies material3's behavior of limiting elevation to 8dp. This was done to workaround a bug on systems older than API level 31 where any content under drop shadows weren't visible to screen readers (source).

https://github.com/saket/cascade/blob/f3840d7ec5d4ce5fa3edf0c0d930cfd08107b456/cascade-compose/src/main/java/me/saket/cascade/Cascade.kt#L202

This is unfortunate because larger shadows look definitely a lot nicer. cascade should read the project's minSdk and allow elevations > 8.dp on API level 31 and above.

saket commented 11 months ago

Done by https://github.com/saket/cascade/commit/92618b5c3b3a2b26337b3fc580daed7822084886