search

saket / press

Cross-platform markdown editor written in Kotlin Multiplatform (work in progress)
1.87k stars 113 forks source link

App shortcut for creating new note #35

Closed msasikanth closed 4 years ago

msasikanth commented 4 years ago

Fixes #1

saket commented 4 years ago

@msasikanth can you also check if your implementation suffers from this problem?

msasikanth commented 4 years ago

@msasikanth can you also check if your implementation suffers from this problem?

This is seems to only happen in emulator, when I tested it on my pixel 3 it's working fine.

saket commented 4 years ago

@msasikanth good to know!

msasikanth commented 4 years ago

I have addressed the PR feedback, but I didn't change the uuid4() in EditorActivity

saket commented 4 years ago

LGTM! The CI is failing because of something on master. I'll push a fix and then merge this.

saket commented 4 years ago

Done. Can you reroll?

msasikanth commented 4 years ago

Done. Can you reroll?

Done

saket commented 4 years ago

Thanks for adding this!