saket / telephoto

Building blocks for designing media experiences in Compose UI
https://saket.github.io/telephoto/
Apache License 2.0
869 stars 28 forks source link

Incorrect alignment of images in RTL layout direction #44

Closed MV-GH closed 10 months ago

MV-GH commented 10 months ago

One of my users reported this issue https://github.com/dessalines/jerboa/issues/1212. In which the image viewer does not always properly center the image in ContentScale.Fit when it is set to RTL. Which does work with LTR.

I made a repro

image

This image is supposed to be completed stretched on the horizontal

see repro https://github.com/MV-GH/ReproChannelCrash/tree/rtl_bug

saket commented 10 months ago

This was a fun bug to fix. Thanks for sending these bug reports @MV-GH. Please keep em coming!

I'll make a new release soon, but in the meantime you can use 0.6.0-SNAPSHOT once this action finishes running: https://github.com/saket/telephoto/actions/runs/6069596982.