search

saket / telephoto

Building blocks for designing media experiences in Compose UI
https://saket.github.io/telephoto/
Apache License 2.0
996 stars 32 forks source link

Exif image rotation for ZoomableAsyncImage w/ coil #48

Closed hvisser closed 1 year ago

hvisser commented 1 year ago

When swapping out AsyncImage with ZoomableAsyncImage exif rotation seems to be ignored. AsyncImage shows my image in the correct orientation, while ZoomableAsyncImage does not.

I saw https://github.com/saket/telephoto/issues/30 marked as fixed so this might have regressed (or never worked for Coil)?

saket commented 1 year ago

Will you be able to share a sample image? I've got a few here but it's possible I'm missing something.

Exif rotation is applied by the bitmap decoder so it should work for all image libraries out of the box

hvisser commented 1 year ago

Ah OK, that was added after 1.0.0-alpha02 though which I was using. With the 0.6.0-SNAPSHOT (and 0.5.0) the rotation is correct.

I guess the confusion is that that release even exists as the docs etc do point to 0.5.0. I didn't see that so I did a maven search and picked the "latest" version.

saket commented 1 year ago

Yea sorry about that. My decision to release a 1.x.x-alpha and then go back to using 0.x was a mistake.

hvisser commented 1 year ago

No worries, it's a great library so thanks for that!