Add keyboard support - Githubissues

evant commented 3 months ago

Intial stab at this, I'm not sure all the code lives in the right place and looking for feedback on that.

Additional issues/questions:

Is there a way to get the 'standard' system keyboard shortcuts for this?
How to detect ctrl/meta + key press? I never saw them detected though I'm testing with the android emulator which does weird things with external keyboards.
keyboard input enabled by default? note: view needs to be focused to start receiving events
configure zoom & pan steps?

Fixes #78

evant commented 2 months ago

Are you blocked on this by any chance?

Nope! We ended up adding separate zoom/pan support on top for keyboard support for now. It does mean you could technically do both independently but it seems to work ok enough.

saket commented 1 month ago

Took me some time, but I'm finally working on this. I'm going ahead and merging this as-is because your code looks great. I'll make a few adjustments and then land the changes on trunk soon. Thanks Eva!

saket / telephoto

Add keyboard support #80