Closed DevangThakkar closed 3 years ago
Hi Saket, running flake8 locally gives a lot of warnings/errors for the existing codebase so it would be useful if you could recap the style conventions that you use/recommend in this project, thanks!
Many thanks for the PR @DevangThakkar! I will take a deeper look soon, but we use black, so you would have to do black .
in the pysradb
directory.
Merging #129 (8d68e97) into master (14ddbfb) will increase coverage by
1.85%
. The diff coverage is78.18%
.
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 56.51% 58.37% +1.85%
==========================================
Files 7 8 +1
Lines 1718 1773 +55
==========================================
+ Hits 971 1035 +64
+ Misses 747 738 -9
Impacted Files | Coverage Δ | |
---|---|---|
pysradb/cli.py | 0.00% <0.00%> (ø) |
|
pysradb/geoweb.py | 93.47% <93.47%> (ø) |
|
pysradb/sraweb.py | 83.13% <0.00%> (+3.17%) |
:arrow_up: |
pysradb/download.py | 28.39% <0.00%> (+5.89%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 14ddbfb...8d68e97. Read the comment docs.
Thanks once again @DevangThakkar! I was unaware of files.txt
existence, pretty nice!
You're welcome @saketkc! Feel free to assign me to future issues. (:
Fixes Issue #120.
The
-g
argument allows downloads of GEO files. This argument can also be used concurrently with-p
. The commands shown below are some valid uses of the argument: