search

saketkc / pysradb

Package for fetching metadata and downloading data from SRA/ENA/GEO
https://saketkc.github.io/pysradb
BSD 3-Clause "New" or "Revised" License
307 stars 50 forks source link

unpin `pandas`? #141

Closed jbloom closed 2 years ago

jbloom commented 3 years ago

Right now pysradb pins pandas to version 1.2.0, even though as far as I can tell this pinning isn't necessary for pysradb. Is it possible to just make the requirement pandas>=1.2.0 so it's possible to use pysradb with newer versions of pandas?

saketkc commented 3 years ago

The hard pinning was specifically designed for the changes introduced in pandas 1.2.0 (the nullable data support that was not part of <1.2) so I agree, it is no longer necessary. I have unpinned all the requirements (and confirmed they don't break the tests).

I will make a release in the coming weeks after merging @Maarten-vd-Sande's #138. For now, you should be able to install from github: pip install git+https://github.com/saketkc/pysradb

saketkc commented 2 years ago

Should be fixed via the latest release