Closed bscrow closed 2 years ago
Merging #144 (4cf507d) into master (b91fd35) will increase coverage by
0.27%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 57.72% 57.99% +0.27%
==========================================
Files 8 8
Lines 1774 1776 +2
==========================================
+ Hits 1024 1030 +6
+ Misses 750 746 -4
Impacted Files | Coverage Δ | |
---|---|---|
pysradb/search.py | 79.84% <100.00%> (+0.03%) |
:arrow_up: |
pysradb/download.py | 28.39% <0.00%> (-0.36%) |
:arrow_down: |
pysradb/sraweb.py | 81.94% <0.00%> (+0.99%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b91fd35...4cf507d. Read the comment docs.
Thanks a lot @bscrow for fixing this so quickly! I have confirmed it fixes both #143 and #142
142 was due to ENA now enforcing case sensitivity on certain fields such as library_strategy. I had previously converted all queries to uppercase (eg RNA-seq was converted to RNA-SEQ instead of RNA-Seq), resulting in the bug. This should be fixed now.
143 was due to a misplaced parenthesis on my part. My apologies.
Small update to test cases in test_search.py to account for the changes.