search

saketkc / pysradb

Package for fetching metadata and downloading data from SRA/ENA/GEO
https://saketkc.github.io/pysradb
BSD 3-Clause "New" or "Revised" License
307 stars 50 forks source link

Pub date #146

Closed bscrow closed 2 years ago

bscrow commented 2 years ago

Fixes #145 where the month and date of publication_date argument has been swapped in SraSearch and GeoSearch. Updated test cases affected by this bug.

image

codecov[bot] commented 2 years ago

Codecov Report

Merging #146 (cf42b39) into master (494c5ac) will increase coverage by 1.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   57.12%   58.13%   +1.01%     
==========================================
  Files           8        8              
  Lines        1775     1782       +7     
==========================================
+ Hits         1014     1036      +22     
+ Misses        761      746      -15
Impacted Files Coverage Δ
pysradb/search.py 80.03% <100.00%> (+0.18%) :arrow_up:
pysradb/download.py 28.39% <0.00%> (-0.36%) :arrow_down:
pysradb/sraweb.py 81.94% <0.00%> (+3.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 494c5ac...cf42b39. Read the comment docs.

saketkc commented 2 years ago

Thanks a lot for fixing this so quickly @bscrow!