search

saketkc / pysradb

Package for fetching metadata and downloading data from SRA/ENA/GEO
https://saketkc.github.io/pysradb
BSD 3-Clause "New" or "Revised" License
303 stars 49 forks source link

Attempt to fix #170 Mismatched gcp and AWS links #174

Closed cksajil closed 1 year ago

cksajil commented 1 year ago

On branch sajil-develop Changes to be committed: modified: pysradb/sraweb.py modified: pysradb/utils.py modified: tests/test_utils.py

saketkc commented 1 year ago

Thanks, though this appears to completely wipe out the AWS and GCP links which is not what we want (also it fails with pysradb metadata --detailed SRP288365)

cksajil commented 1 year ago

@saketkc can I place the AWS and GCP links in new columns or do you want to place those is any of the existing columns?

saketkc commented 1 year ago

Putting them into new column(s) should be fine.

cksajil commented 1 year ago

@saketkc I added the links to new columns. Let me know if this is fine.

saketkc commented 1 year ago

Thanks @cksajil for helping with this! I have added some comments on the PR that would be good to address before we can merge this.

saketkc commented 1 year ago

Hi @cksajil, with PR #177, I believe the original issue has been addressed. Thanks once again for helping with the fix.