saketkc / pysradb

Package for fetching metadata and downloading data from SRA/ENA/GEO
https://saketkc.github.io/pysradb
BSD 3-Clause "New" or "Revised" License
303 stars 49 forks source link

Handle all links #177

Closed saketkc closed 1 year ago

saketkc commented 1 year ago

This PR adds support for handling all links outputted by the NCBI API instead of relying on partial matches to AWS/GCP.

saketkc commented 1 year ago

Closes #170

codecov[bot] commented 1 year ago

Codecov Report

Base: 58.70% // Head: 59.04% // Increases project coverage by +0.33% :tada:

Coverage data is based on head (b496f6e) compared to base (18757f1). Patch coverage: 91.02% of modified lines in pull request are covered.

:exclamation: Current head b496f6e differs from pull request most recent head 250766d. Consider uploading reports for the commit 250766d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #177 +/- ## ========================================== + Coverage 58.70% 59.04% +0.33% ========================================== Files 8 8 Lines 1821 1836 +15 ========================================== + Hits 1069 1084 +15 Misses 752 752 ``` | [Impacted Files](https://codecov.io/gh/saketkc/pysradb/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [pysradb/cli.py](https://codecov.io/gh/saketkc/pysradb/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlzcmFkYi9jbGkucHk=) | `0.00% <ø> (ø)` | | | [pysradb/sraweb.py](https://codecov.io/gh/saketkc/pysradb/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlzcmFkYi9zcmF3ZWIucHk=) | `82.88% <90.90%> (+0.47%)` | :arrow_up: | | [pysradb/\_\_init\_\_.py](https://codecov.io/gh/saketkc/pysradb/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlzcmFkYi9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.