saketkc / pysradb

Package for fetching metadata and downloading data from SRA/ENA/GEO
https://saketkc.github.io/pysradb
BSD 3-Clause "New" or "Revised" License
303 stars 49 forks source link

Fix SRX -> SRR conversion #183

Closed tfehlmann closed 1 year ago

tfehlmann commented 1 year ago

This fixes #182. The problem was that the same dictionary was modified and referenced by each element of the list. Also fixes 4 test errors where the srr_to or srs_to function would return a df with other accessions in addition to the requested one.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.19 :warning:

Comparison is base (301193b) 59.04% compared to head (29de3b3) 58.85%.

:exclamation: Current head 29de3b3 differs from pull request most recent head c5f06e0. Consider uploading reports for the commit c5f06e0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #183 +/- ## =========================================== - Coverage 59.04% 58.85% -0.19% =========================================== Files 8 8 Lines 1836 1857 +21 =========================================== + Hits 1084 1093 +9 - Misses 752 764 +12 ``` | [Impacted Files](https://codecov.io/gh/saketkc/pysradb/pull/183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [pysradb/sraweb.py](https://codecov.io/gh/saketkc/pysradb/pull/183?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cHlzcmFkYi9zcmF3ZWIucHk=) | `81.42% <100.00%> (-1.46%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

saketkc commented 1 year ago

Thank you @tfehlmann! This was a good opportunity to fix a bunch of things.

tfehlmann commented 1 year ago

Thank you for the super fast integration!