Closed jggatter closed 11 months ago
Ah wow, that's a lot of flake8 violations.
Happy to address them, but not sure if you have your own opinions about these rules.
Furthermore, a tool like pre-commit
could be useful.
Thanks for your PR and contributions! Easisest way to fix the flake8 issues is to run black
.
Patch coverage: 37.50%
and project coverage change: -0.90%
:warning:
Comparison is base (
cd33b70
) 59.53% compared to head (06d8441
) 58.63%. Report is 21 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks so much for merging and publishing the PRs! If you're looking for more contributions let me know!
test_geo_search_1
was failing on all branches. The eLink request withinGeoSearch.search()
seemed to return an empty body despite receiving status code 200 and healthy response headers. Changing'retmode': 'xml'
seems to generate the desired output.The test seems to take a long time to run. I tested the code I changed to make sure it wasn't the cause. I'm not sure whether this performance differs from calls made in the past.
It may be worth reaching out to NCBI to understand why
the request with 'retmode': 'json'
stopped working.This should unblock #198 #199 and any future PRs