Tests for commands of the SRAweb module

[dibyaaaaax]

@saketkc could you please review the tests I have written? I will complete the rest of them once I am sure I'm going in the right direction.

[saketkc]

Looks good! Can you rebase with master? You might get conflicts, but they should be easy to resolve.

[dibyaaaaax]

I don't understand why Travis fails while running the tests. I didn't get any error while running them on my machine. @saketkc could you please help me out?

[saketkc]

Thanks @dibyaaaaax! This looks like a good solid test set. Sorry for the delay in getting back to you, I was traveling.

The failure on Python 3.7 appears to be a random failure. I have restarted the build. Let's see if it goes through. If not, I will have to dig deeper.

[dibyaaaaax]

Thank you @saketkc! Hope it works :smiley:

[saketkc]

Something still wrong with Py3.7. I will have to dig deeper.

[saketkc]

HI @dibyaaaaax, thanks for your continued patience. We are almost there. The error is because of tests exceeding the API rate limits. A simple fix wouldbe to add time.sleep(1) in the fixture:

@pytest.fixture(scope="module")
def sraweb_connection():
    db = SRAweb()
    time.sleep(1)
    return db

[dibyaaaaax]

@saketkc the API rate limit exceeds even with the sleep time.

[saketkc]

Can you give me edit permissions for this PR @dibyaaaaax? Thanks! https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

[dibyaaaaax]

@saketkc you already have the edit permission.

[saketkc]

@dibyaaaaax, thanks a lot for this major effort! We are good to go to the master.

[saketkc]

Are you okay with me adding your Name to AUTHORS?

Contributors

• Dibya Gautam https://github.com/dibyaaaaax

[dibyaaaaax]

yeah sure, thanks a lot @saketkc!