fix collisions of ena_urls in merge

saketkc / pysradb

Package for fetching metadata and downloading data from SRA/ENA/GEO

https://saketkc.github.io/pysradb

BSD 3-Clause "New" or "Revised" License

311 stars 51 forks source link

Closed Maarten-vd-Sande closed 4 years ago

Maarten-vd-Sande commented 4 years ago

When merging from multiple srp's the current approach keeps adding columns with _x and _y to avoid collisions.

I replaced the pandas merge function with update since we actually want to overwrite the nan values.

Related to #56

Maarten-vd-Sande commented 4 years ago

Not sure if I should worry about the tests

saketkc commented 4 years ago

This looks great @Maarten-vd-Sande! Thanks a lot. The travis failures are not related to this, so I will go ahead and merge.