Closed Maarten-vd-Sande closed 4 years ago
Merging #63 into master will increase coverage by
1.08%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 41.92% 43.00% +1.08%
==========================================
Files 5 5
Lines 1028 1030 +2
==========================================
+ Hits 431 443 +12
+ Misses 597 587 -10
Impacted Files | Coverage Δ | |
---|---|---|
pysradb/sraweb.py | 86.33% <100.00%> (+2.23%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d567adb...8793bef. Read the comment docs.
As mentioned in #61 I thought the "long" duration for my lookups came from unnecessary waits. However the main duration of
pysradb.SRAweb.sra_metadata
is actually spent in waiting for ENA to reply. By doing the requests to ENA in a threadpool we can speed up this process significantly:This goes from 36.8 to 15.5 seconds.
It can be sped up even more by increasing the amount of threads in the pool, but I think ENA would not appreciate that.