search

saketkc / pysradb

Package for fetching metadata and downloading data from SRA/ENA/GEO
https://saketkc.github.io/pysradb
BSD 3-Clause "New" or "Revised" License
310 stars 51 forks source link

Add library_name #85

Closed Phlya closed 3 years ago

Phlya commented 3 years ago

Fix for https://github.com/saketkc/pysradb/issues/84

saketkc commented 3 years ago

Thanks Ilya for the PR (and for creating adjustText!:-) I will have to take a deeper look as the tests are failing, but I think I did miss out that field earlier.

Phlya commented 3 years ago

I think for some tests they need to be updated, and looks like maybe this field is not available in all SRA entries, so would need to add try/except when assigning the variable I guess? Or if it has a .get() method add a default empty string?

saketkc commented 3 years ago

Thanks @Phlya!