sakhnik / nvim-gdb

Neovim thin wrapper for GDB, LLDB, PDB/PDB++ and BashDB
723 stars 39 forks source link

Debugger start regression from 4357472 #167

Closed davxy closed 2 years ago

davxy commented 2 years ago

Hey Anatolii. From commit https://github.com/sakhnik/nvim-gdb/commit/4357472e675044222d8ba2f89a95a78fed958560 I'm experiencing a regression wrt debugger first start.

In particular when I start the debugger for the 1st time I get the following error:

Screenshot from 2022-05-02 10-25-39

If I ignore the error, close the debugger and I restart the debugger the error is not shown and I'm able to debug but all shortcuts are not working (F8, F10, etc).

See the video asciicast

sakhnik commented 2 years ago

Hi Davide, what version of Neovim are you using? That change utilizes the new API from the recently released 0.7.

davxy commented 2 years ago

I'm using Debian Sid (unstable) and at the moment we are at v0.6.1... Stable is still at 0.4 :-) See here

From what I can see at the moment both Ubuntu and Fedora stable ship with 0.6.1 as well.

So today your change may impact a lot of people (maybe almost everyone not using Arch or NixOs :-D )

What you suggest? Maybe the change requiring v0.7 can wait a couple of months? Or maybe there is a workaround?

sakhnik commented 2 years ago

There're lots of ways. First of all, anyone could just use an official appimage, or revert the last merge commit in the local plugin repo. The plugin is only tested against the latest version of Neovim. But I see your point and there's no need to push everyone. So I'm going to revert the last change for now.

davxy commented 2 years ago

Indeed I was using the commit before the one I've mentioned. But as you can imagine a lot of people is using your plugin via a plugin manager that pulls directly from master.

Maybe you can keep this issue open just to remember to restore the modifications once that the major distros switched to 0.7? I'll keep you informed as soon as v0.7 is in the upstream for Debian Testing/Ubuntu/Fedora.

Thank you for the revert :-D Your plugin is awesome ;-)

sakhnik commented 2 years ago

No worries, it just occurred to me that maybe we could maintain a couple of branches like still and fresh. The first one fetched by default should be suitable for everybody, the latter rather for evolution. Take care!