sakhnyuk / rc-scrollbars

React scrollbars component
https://rc-scrollbars.vercel.app/
MIT License
145 stars 14 forks source link

RTL issue #12

Closed Benyamin001 closed 3 years ago

Benyamin001 commented 3 years ago

Hi in RTL page vertical scroll bar appear in left side of elements and its visible when use rc-scrollbars in version 1.0.0 the main div have scrollBar class name and with this class , I fix this issue in my project but in version 1.0.3 scrollBar class removed and all scroll bar visible again

Tomassito commented 3 years ago

Hi @Benyamin001, we have already discussed briefly with @sakhnyuk an improvement that would let you pass classnames for any of the subcomponents. You can expect a PR this week and live changes as soon as it gets reviewed.

sakhnyuk commented 3 years ago

@Benyamin001 Yes, I've removed the "scrollView" className, because it doesn't use in the project anymore. But you can add your custom className by passing renderView prop.

      <Scrollbars renderView={props => <div {...props} className="scrollView"/>}>
        {children}
      </Scrollbars>

As said @Tomassito, in future updates, we have plans to add special props for classnames.

Also, I think about the RTL support feature. This is an important option too.

Tomassito commented 3 years ago

@Benyamin001 Could you confirm that you could handle your issue with the solution proposed?

Benyamin001 commented 3 years ago

it's working, thanks

paymanzafar1 commented 11 months ago

Hi @sakhnyuk.

RTL language support is a required feature. I am using Rocket.Chat software that uses this component. All the horizontal scrollbars do not work, and the vertical ones have margin problem.

Please add this feature as soon as possible. Thank you.