search

sakhnyuk / rc-scrollbars

React scrollbars component
https://rc-scrollbars.vercel.app/
MIT License
145 stars 14 forks source link

Export Props interface #13

Closed vdjurdjevic closed 3 years ago

vdjurdjevic commented 3 years ago

Hi. Thanks for restoring the project! Can you rename Props interface to something like ScrollbarProps and export it so we can extend it from the outside?

Tomassito commented 3 years ago

@vdjurdjevic That's a totally valid request. @sakhnyuk I can make it part of the https://github.com/sakhnyuk/rc-scrollbars/pull/11 ?

vdjurdjevic commented 3 years ago

@Tomassito That would be great :)

sakhnyuk commented 3 years ago

@vdjurdjevic Hi 👋

Sure! I think with ScrollbarProps, we need to export ScrollValues.

Actually, If you want to help with that, you can open a PR. If not, I'll do it in a few days

vdjurdjevic commented 3 years ago

Can @Tomassito do it with the existing pull request since it's really a minor change?

nnennajohn commented 3 years ago

Could you please add className prop to props, in addition to existing style prop? Thanks.

vdjurdjevic commented 3 years ago

@nnennajohn @sakhnyuk Actually, we should add all div props, and forward them to the root element.

sakhnyuk commented 3 years ago

@vdjurdjevic @nnennajohn I've done it in 1.1.0