Closed Zloka closed 3 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/sakhnyuk/rc-scrollbars/BRtW5nFPkJkNVDUdWWKSzHVu6KjD
✅ Preview: https://rc-scrollbars-git-fork-zloka-support-htmldivelement-pro-7eab6c.vercel.app
Updated PR to include only id
prop after discussion in the related issue.
This PR aims to add support for props that are assigned to the root element.
In my particular case, I would need to add support for the
id
property. My use-case is that I use the Intersection Observer API to measure the offset relative to some parent, and the parent is identified using theid
property. In practice, this is used to lazily load content (for example images) within a scrollable container, which is a fairly common use-case.The
prepublish
andbuild:docs
scripts run just fine but I wasn't able to run the tests locally, seemingly because of issues with the webpack configuration. If I can get some pointers on that, I'll happily add a few test cases as well.This is the output I get when attempting to run the tests: