sakhtar1979 / onejar-maven-plugin

Automatically exported from code.google.com/p/onejar-maven-plugin
0 stars 0 forks source link

Cant specify JarClassLoader for One-jar, need to because of spring url loading #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create an application that involves the ClassPathResource of spring and load 
a URL from that.

What is the expected output? What do you see instead?
- Cant load the resource since the url is built up incorrectly for spring to 
use. Specifying the 
"<One-Jar-URL-Factory>com.simontuffs.onejar.JarClassLoader$OneJarURLFactory</One
-Jar-URL-Factory>" setting solves the matter, but we cant specify it in the 
maven plugin config!

What version of onejar-maven-plugin are you using?
1.4.4

What is the output of "mvn -version" on your machine?
Apache Maven 3.0.3 (r1075438; 2011-02-28 18:31:09+0100)
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.0.0-13-generic", arch: "amd64", family: "unix"

Please provide any additional information below.
If you let me send you a patch, then I might be able to add an option to supply 
some extra one-jar specific config settings for all kinds of corner cases.

Original issue reported on code.google.com by bwijsmul...@gmail.com on 21 Dec 2011 at 1:33

GoogleCodeExporter commented 9 years ago
Here's a patch that works for me, please include it. I really need this stuff.
This allows to specify any kind of manifest entry in the pom that will be 
directly passed to the one-jar manifest.

Is this project still alive?

Anyways, if nobody replies I'm afraid I'll be forced to fork off a version of 
this project for others to enable them to keep using one-jar with maven.

Original comment by bwijsmul...@gmail.com on 10 Jan 2012 at 6:27

Attachments:

GoogleCodeExporter commented 9 years ago
Hi Braam!

Thanks for the patch. I have added project committer permissions to you, so you 
should be able to commit code to the svn repo, as well as update status on 
issues in the issue tracker.

Personally, I have unfortunately not had (and will not have in any forseeable 
future) time to prioritise this project. If you are interested in pushing this 
project forward, that is much appreciated. Let me know whatever else you need.

Thanks,
Hugo

Original comment by h...@josefson.org on 11 Jan 2012 at 5:54

GoogleCodeExporter commented 9 years ago
Thanks, I'll commit my code asap!

Original comment by bwijsmul...@gmail.com on 12 Jan 2012 at 8:35

GoogleCodeExporter commented 9 years ago
I'll handle this one.

Original comment by bwijsmul...@gmail.com on 12 Jan 2012 at 8:37

GoogleCodeExporter commented 9 years ago
1.4.5-SNAPSHOT offers the new option, it's currently available.

Original comment by bwijsmul...@gmail.com on 12 Jan 2012 at 10:47