search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
220 stars 33 forks source link

High cpu usage when media is playing #135

Open cmm opened 4 months ago

cmm commented 4 months ago

To Reproduce

  1. Cause the popup "menu" (I mean, is it a menu?) to show, using whatever configured shortcut
  2. Observe that your music is suddenly getting obscured by the fan sound
  3. Open "top"
  4. See gnome-shell up there, very busy doing who knows what

I lack the skills to diagnose this any more precisely, sorry.

Thankfully disabling/enabling the extension clears the condition -- until you happen to open the popup again, that is.

Desktop (please complete the following information):

Smartphone (please complete the following information): You may want to edit this bug report template? :smile:

ChrisLauinger77 commented 4 months ago
  1. open a terminal
  2. type "sudo journalctl -f" (without quotes)
  3. show the pop up menu
  4. post the output from terminal here

@sakithb I have the feeling it is the same which I told you in a discussion and its related to slider. (I made a local change to not have the slider for now) But lets see

cmm commented 4 months ago

there's nothing at all output to the journal when I open the popup, alas.

sakithb commented 4 months ago

  1. open a terminal

    1. type "sudo journalctl -f" (without quotes)

    2. show the pop up menu

    3. post the output from terminal here

@sakithb I have the feeling it is the same which I told you in a discussion and its related to slider. (I made a local change to not have the slider for now) But lets see

That could be true.

sakithb commented 4 months ago

there's nothing at all output to the journal when I open the popup, alas.

Is it recreatable while playing a track with no album art?

cmm commented 4 months ago

there's nothing at all output to the journal when I open the popup, alas.

Is it recreatable while playing a track with no album art?

it is.

ChrisLauinger77 commented 4 months ago

We can try If you have the same problem I have on debian testing. Use this version of PanelButton.js which disables the Slider: PanelButton.zip It goes to ".local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell"

cmm commented 4 months ago

We can try If you have the same problem I have

yep, confirmed: no slider, no problem.

ChrisLauinger77 commented 4 months ago

So this means our distros need to update I guess. I am on debian testing - you are NIXOS unstable.

cmm commented 4 months ago

So this means our distros need to update I guess. I am on debian testing - you are NIXOS unstable.

you mean our respective gnome-shell versions are too old, or something else?

ChrisLauinger77 commented 4 months ago

Not really sure If it is gnome-shell, gjs, mutter, clutter etc. But Fedora users seem to be not affected by this.

cmm commented 4 months ago

interesting! another reason could be some quirk of a particular MPRIS2 server implementation. when I was experiencing the problem the player was MPD behind mpdris2. too lazy to revert the patch and check other players now. (I'm actually kind of surprised to learn that MPRIS2 is capable of showing/controlling track position at all)

cmm commented 4 months ago

@sakithb an acceptable solution of sorts could be just providing a config knob to disable the slider.

ChrisLauinger77 commented 4 months ago

@sakithb an acceptable solution of sorts could be just providing a config knob to disable the slider.

U are using an unstable distro. You should accept that problems might be there. Me as well. It will work as soon as some update comes. I workarounded the problem for me (and you). Fine for now I guess.

Spurlos commented 4 months ago

Using Ubuntu 23.10, with Media Controls v34. Getting freezes on play start (in particular youtube) and memory leak in Gnome Shell while using Spotify for long periods (typical work day). Tracked it down to this extension.

Here is some bits of relevant logs from journal around the freeze time:

Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d3fbe40 StBoxLayout:insensitive ("Cмута показала геймплей, графика будущего, PlayStation в беде, во что поиграть? Игровые новости!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1edf6da0 StLabel:insensitive ("Cмута показала геймплей, графика будущего, PlayStation в беде, во что поиграть? Игровые новости!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1f30b4b0 StBoxLayout:insensitive ("ТАК ОСТРО!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1731df50 StLabel:insensitive ("ТАК ОСТРО!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1b7ac990 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a745bb0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f53035ea0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a80bfa0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a9eb570 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19906980 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f197babc0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19d88840 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19bc94a0 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d8b21f0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1ce3b680 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f17a4c480 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1980ef30 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a57abd0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f18654d80 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f3f2771a0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d0b7290 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f16d2f260 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1e3bcd60 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f3f3b93d0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a8cb480 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1cee7190 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f194e63e0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1724e370 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:14:41 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: [Media Controls] Error: Failed to call listener for property IsInvalid: TypeError: this.playerProxies is null
                                                                setActivePlayer@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/extension.js:375:13
                                                                addPlayer/<@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/extension.js:355:22
                                                                callOnChangedListeners@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:118:25
                                                                validatePlayer@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:98:14
                                                                callOnChangedListeners@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:118:25
                                                                initPlayer/<@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:37:22
                                                                _callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
                                                                _emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
                                                                _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
                                                                @resource:///org/gnome/shell/ui/init.js:21:20
ChrisLauinger77 commented 4 months ago

Using Ubuntu 23.10, with Media Controls v34. Getting freezes on play start (in particular youtube) and memory leak in Gnome Shell while using Spotify for long periods (typical work day). Tracked it down to this extension.

Here is some bits of relevant logs from journal around the freeze time:

Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d3fbe40 StBoxLayout:insensitive ("Cмута показала геймплей, графика будущего, PlayStation в беде, во что поиграть? Игровые новости!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1edf6da0 StLabel:insensitive ("Cмута показала геймплей, графика будущего, PlayStation в беде, во что поиграть? Игровые новости!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1f30b4b0 StBoxLayout:insensitive ("ТАК ОСТРО!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1731df50 StLabel:insensitive ("ТАК ОСТРО!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1b7ac990 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a745bb0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f53035ea0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a80bfa0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a9eb570 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19906980 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f197babc0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19d88840 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19bc94a0 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d8b21f0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1ce3b680 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f17a4c480 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1980ef30 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a57abd0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f18654d80 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f3f2771a0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d0b7290 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f16d2f260 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1e3bcd60 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f3f3b93d0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a8cb480 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1cee7190 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f194e63e0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1724e370 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:14:41 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: [Media Controls] Error: Failed to call listener for property IsInvalid: TypeError: this.playerProxies is null
                                                                setActivePlayer@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/extension.js:375:13
                                                                addPlayer/<@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/extension.js:355:22
                                                                callOnChangedListeners@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:118:25
                                                                validatePlayer@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:98:14
                                                                callOnChangedListeners@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:118:25
                                                                initPlayer/<@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:37:22
                                                                _callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
                                                                _emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
                                                                _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
                                                                @resource:///org/gnome/shell/ui/init.js:21:20

This seems to be something different and not related to the slider. But to be sure - can you try with the attached PanelButton.js from this post: https://github.com/sakithb/media-controls/issues/135#issuecomment-1939069885

ChrisLauinger77 commented 4 months ago

@sakithb I think I know how to reproduce the slider issue: It only happens to me when I open spotify and start playback with button in the spotify desktop client. Then after some seconds I open the panel menu and see the slider starts from 0 and is not synced with the spotify client. And some seconds later the spamming starts and gnome shell goes nuts. When I open spotify-client and start playback with the panelmenu button - its works and it also does not spam / slider is sync. Can you try If you can reproduce it with this flow of events ?

ChrisLauinger77 commented 4 months ago

After a song changes - it can happen again. Somehow the panelbutton slider runs auf of sync with the song position and then it starts spamming.

sakithb commented 4 months ago

After a song changes - it can happen again. Somehow the panelbutton slider runs auf of sync with the song position and then it starts spamming.

Okay, I will take a look at that during the next week

ChrisLauinger77 commented 4 months ago

After a song changes - it can happen again. Somehow the panelbutton slider runs auf of sync with the song position and then it starts spamming.

Okay, I will take a look at that during the next week

I have the feeling the slider should only run when the panelbutton is shown. When the panelbuttion is not shown it should be stopped (nobody can see the animation anyways) Then it can not run out of sync with the song. I think I try that out now

ChrisLauinger77 commented 4 months ago

Bildschirmfoto vom 2024-02-24 08-10-37 Here you can see the song (1:39) is out of sync with the slider (1:41) and I have the feeling when this happens the spamming starts at the end of the song when the slider is ahead of the song time.

Spurlos commented 4 months ago

Using Ubuntu 23.10, with Media Controls v34. Getting freezes on play start (in particular youtube) and memory leak in Gnome Shell while using Spotify for long periods (typical work day). Tracked it down to this extension. Here is some bits of relevant logs from journal around the freeze time:

Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:23 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:24 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d3fbe40 StBoxLayout:insensitive ("Cмута показала геймплей, графика будущего, PlayStation в беде, во что поиграть? Игровые новости!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1edf6da0 StLabel:insensitive ("Cмута показала геймплей, графика будущего, PlayStation в беде, во что поиграть? Игровые новости!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1f30b4b0 StBoxLayout:insensitive ("ТАК ОСТРО!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1731df50 StLabel:insensitive ("ТАК ОСТРО!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1b7ac990 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a745bb0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f53035ea0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a80bfa0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a9eb570 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19906980 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f197babc0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19d88840 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f19bc94a0 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d8b21f0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1ce3b680 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f17a4c480 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1980ef30 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a57abd0 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f18654d80 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f3f2771a0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1d0b7290 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f16d2f260 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1e3bcd60 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f3f3b93d0 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1a8cb480 StBoxLayout:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1cee7190 StLabel:insensitive ("[СТРИМ] Забудьте про Diablo. Last Epoch 1.0 вышла!")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f194e63e0 StBoxLayout:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:25 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: st_widget_get_theme_node called on the widget [0x561f1724e370 StLabel:insensitive ("iXBT games")] which is not in the stage.
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: invalid (NULL) pointer instance
Feb 23 03:12:26 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: g_signal_handler_disconnect: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
Feb 23 03:14:41 spurlos-ThinkPad-T16-Gen-2 gnome-shell[627284]: [Media Controls] Error: Failed to call listener for property IsInvalid: TypeError: this.playerProxies is null
                                                                setActivePlayer@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/extension.js:375:13
                                                                addPlayer/<@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/extension.js:355:22
                                                                callOnChangedListeners@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:118:25
                                                                validatePlayer@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:98:14
                                                                callOnChangedListeners@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:118:25
                                                                initPlayer/<@file:///home/spurlos/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell/PlayerProxy.js:37:22
                                                                _callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
                                                                _emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
                                                                _convertToNativeSignal@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:152:19
                                                                @resource:///org/gnome/shell/ui/init.js:21:20

This seems to be something different and not related to the slider. But to be sure - can you try with the attached PanelButton.js from this post: #135 (comment)

The new PanelButton has solved my issues. My test case was to open any youtube video using Metastream (https://getmetastream.com/ for reference). With old PanelButton it freezes the whole gnome-shell for a while (as its probably does multiple seek requests under the hood to sync the video on everyone sessions). New PanelButton has no such issues.

sakithb commented 2 months ago

@ChrisLauinger77 Do you still get these issues with the release on EGO?

ChrisLauinger77 commented 2 months ago

Yes it is still the same log spamming and i again disabled the slider.

cmm commented 2 months ago

PSA: meanwhile, https://github.com/Moon-0xff/gnome-mpris-label works great. admittedly it has an easier job because it does not try to be a full-blown player UI

sakithb commented 2 months ago

PSA: meanwhile, https://github.com/Moon-0xff/gnome-mpris-label works great. admittedly it has an easier job because it does not try to be a full-blown player UI

The issue occurs because of the slider, I will try to find ways to optimize it when I get some time.

Spurlos commented 1 month ago

The PanelButton.js in this thread is seems outdated now and the extension does not works when file is replaced on latest release v2.0.1

@ChrisLauinger77 can you please post an updated version? I have been able to get OOM after a few hours of youtube binging on 2x-3x speed with regular PanelButton from the latest update.

ChrisLauinger77 commented 1 month ago

@Spurlos Yes sure - I attach it to the thread you mentioned in the evening

ChrisLauinger77 commented 1 month ago

PanelButton_2.0.1.zip for 2.0.1 without slider It goes to ".local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/helpers/shell"

ChrisLauinger77 commented 3 weeks ago

I yesterday updated my monitor config. I replaced my 2 24 inch with 1 49inch (DualWide). Now I cannot reproduce it any more. The slider behaves still not sync with the player but the spamming and other strange side effects are gone. Which explains why I could not reproduce it in my Fedora VM. Can anybody confirm this finding ? I guess it is more a gnome issue then one for the extension then. I aslo installed a new extension - autohidetopbar - but I think this is not related ...

iconoclasthero commented 2 days ago

What are we considering high cpu usage on an ubuntu-like os running gnome 46? I found this thread looking to see if mpd was supported and I'm seeing 10x higher cpu usage with media-controls running (ca. 30% vs. ca. 3% for gnome-shell reported by htop).