search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
236 stars 36 forks source link

Drag Problem #151

Open oguzhaniptes opened 4 months ago

oguzhaniptes commented 4 months ago

Describe the bug I encountered the issue of the GNOME desktop crashing when I held down the extension while dragging it anywhere.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Topbar'
  2. Click on Extension'
  3. Drag to 'Enywhere'
  4. See error

Expected behavior Open media control panel.

Environment:

ChrisLauinger77 commented 4 months ago

I cannot drag the extension anywhere ... Not sure how you manage that ... Can you record it and post here ?

oguzhaniptes commented 4 months ago

I just clicked and dropped it somewhere. It's very strange, I discovered it by mistake

https://github.com/sakithb/media-controls/assets/53427115/5a6c0c61-c7f8-4a32-b964-bfc7b4324de8

ChrisLauinger77 commented 4 months ago

The scrolling is enabled. I tried it without scrolling. Nothing happenend ...

chase1k commented 4 months ago

I have the same issue as oguzhaniptes. Any clicking and dragging causes it to crash.

sakithb commented 4 months ago

The crash logs point to this line, https://github.com/sakithb/media-controls/blob/eeb83ab018924850d22a444de6b457f119a075e4/src/helpers/shell/PanelButton.ts#L870

I don't have any idea what is going wrong here, but I will investigate later.

ChrisLauinger77 commented 4 months ago

I do not see any crash logs here ? But seems the device at index "tapAction.nTouchPoints - 1" is not there ? I have still not even an idea how to reproduce this - OR it just does not happen on debian ...

sakithb commented 4 months ago

I do not see any crash logs here ? But seems the device at index "tapAction.nTouchPoints - 1" is not there ? I have still not even an idea how to reproduce this - OR it just does not happen on debian ...

I didn't post the logs here, but I was able to reproduce it on fedora.

ChrisLauinger77 commented 4 months ago

I C. Maybe trace out "tapAction.nTouchPoints" - I have the feeling it returns 0 under some cirumstances and then the -1 is not a good idea ...

sakithb commented 3 months ago

Seems like that isn't the issue. I tried by clamping the no of points to always be 0 or greater. Even after commenting out that code, it still crashes. My guess this is an error in the implementation of tap action itself.