search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
236 stars 36 forks source link

Option to align the pop-up to left or right, or add minimum width #37

Closed KristianOde closed 8 months ago

KristianOde commented 2 years ago

When you use the pop-up menu to play the next song, the pop-up menu will adjust it's position if the displayed text on the panel isn't the same as the previous song. This makes sense as the pop-up is centered based on width of the panel entry, but I feel like it's awkward to use if you keep skipping songs using the pop-up menu. Maybe you could add an option to align the pop-up to one of the sides of the panel item to make it's position always be the same. Alternatively, add a minimum widget width alongside the max option to have the panel item always the same size (this would probably be a better solution). I hope my request makes sense.

sakithb commented 2 years ago

Alright, I will add this in the next update.

ChrisLauinger77 commented 12 months ago

I think I would rename the "max widget with" to "widget with" and add an option (toggle) if it should be threated as max (the current behaviour) or as fixed (what the issue asks for). AS for me - this is really low prio. I am fine with the current behaviour tbh.

ChrisLauinger77 commented 10 months ago

An idea: how about let the track info menu size just be the same size as track label menu ?

sakithb commented 10 months ago

An idea: how about let the track info menu size just be the same size as track label menu ?

I have no idea, I tried to do this in the past but failed if I remember correctly, are you working on this issue? If not I can start working on this.

ChrisLauinger77 commented 10 months ago

Really U failed ? Would it not be the same code where you set the size of track label menu ? I am not working on that (I just made the final commit for #40 today) - I just had this idea and it would also not require an additional setting. Max widget size (for both widgets)

sakithb commented 10 months ago

Really U failed ? Would it not be the same code where you set the size of track label menu ? I am not working on that (I just made the final commit for #40 today) - I just had this idea and it would also not require an additional setting. Max widget size (for both widgets)

I think I misunderstood you. Isn't that how it works already? both the track info menu and the track label take the same width set with max widget width;

ChrisLauinger77 commented 10 months ago

Really U failed ? Would it not be the same code where you set the size of track label menu ? I am not working on that (I just made the final commit for #40 today) - I just had this idea and it would also not require an additional setting. Max widget size (for both widgets)

I think I misunderstood you. Isn't that how it works already? both the track info menu and the track label take the same width set with max widget width;

No not for me. When I set max widget with to 500 for example only the track label adjusts the size. Track info stays 200.