search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
236 stars 36 forks source link

Remove warnings in the GJS console #39

Closed G-dH closed 11 months ago

G-dH commented 2 years ago

https://github.com/cliffniff/media-controls/issues/28#issuecomment-940590085 https://github.com/cliffniff/media-controls/blob/a6187136e104eafd46aedf002e4a455df040cc1c/prefs.js#L183 gjs in 3.36 doesn't know ?? operator, it's too new.

sakithb commented 2 years ago

I fixed this in the latest release. Are you sure you are on the latest version?

G-dH commented 2 years ago

See for yourself, I linked your own code in the main branch, didn't find anything newer. Btw the extension itself fills my log with Ignoring length property that isn't a number at line ... and clutter_actor_remove_child: assertion 'child->priv->parent != NULL' failed. But otherwise it works, thanks for your work!

sakithb commented 2 years ago

Oh I am sorry, I remember fixing that, but somehow I haven't pushed it I guess. I will add the changes.

G-dH commented 2 years ago

So you don't care about the other bugs 😉

sakithb commented 2 years ago

Haha, no they are just warnings, nothing harmful. They are printed out when a song or a button updates. I guess I will have to cleanup them I guess.

G-dH commented 2 years ago

I was just curious, I would fix it myself, because I hate unnecessary warnings. I'm also developing extensions and therefore I'm watching the log constantly :)

sakithb commented 2 years ago

Oh nice. I will fix up the warnings when I have some time. If you could fix it, of course it would be appreciated. Also I will change the title to removing warnings.

ChrisLauinger77 commented 11 months ago

I could get rid of the clutter_actor_remove_child: assertion 'child->priv->parent != NULL' failed. messages in main and gnome44. But I have no idea where the Ignoring length property that isn't a number at line ... messages are coming from @sakithb0 @G-dH Any hint what I have to check ?

G-dH commented 11 months ago

@ChrisLauinger77 Check stylesheet.css ;)

Ignoring length property that isn't a number at line 22, col 18
Ignoring length property that isn't a number at line 21, col 17
ChrisLauinger77 commented 11 months ago

@ChrisLauinger77 Check stylesheet.css ;)

Ignoring length property that isn't a number at line 22, col 18
Ignoring length property that isn't a number at line 21, col 17

Ah that lines are about stylesheet.css - barely use it in my other extensions. Thx for pointing that out.

ChrisLauinger77 commented 11 months ago

main and gnome44