search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
224 stars 33 forks source link

Can I change the padding of the icon? #68

Closed trolliama closed 9 months ago

trolliama commented 1 year ago

I am using ubuntu 22.04 and added the dash to panel extension. In my workspace the spotify icon have a big margin/padding

image image image

Can I change this on the extension config/source code?

JadeVane commented 1 year ago

I have the same problem now, have you found a solution now?

trolliama commented 1 year ago

I have the same problem now, have you found a solution now?

Not yet. I actually stopped trying. If someone reply with some hint I will try again

ChrisLauinger77 commented 9 months ago

It is not a setting. But it is in stylesheet.css. If I am not misstaken this is the setting which is applied: .popup-menu-button { border-radius: 99px; padding: 0.4em; margin: 0.1em; }

sakithb commented 9 months ago

It is not a setting. But it is in stylesheet.css. If I am not misstaken this is the setting which is applied: .popup-menu-button { border-radius: 99px; padding: 0.4em; margin: 0.1em; }

Should we add it as a setting?

ChrisLauinger77 commented 9 months ago

@cliffniff I do not know. Some many padding questions / requests. Should this rather be controlled by the theme then by the extension ? What should come from the theme ?- Should the extension even overrule the theme ? Settings left - center - right is nice. Index of the extension is also nice. IMHO that's the only thing we need. Rest should be done by the theme - that is what it is for.

ChrisLauinger77 commented 9 months ago

mouse over Bildschirmfoto vom 2023-10-09 19-02-07 clicked Bildschirmfoto vom 2023-10-09 19-02-14 with title clicked Bildschirmfoto vom 2023-10-09 19-05-09

with controls clicked Bildschirmfoto vom 2023-10-09 19-07-37

on mouseover everthing is fine. but when clicked it gets bigger. I do not see a need to change anyhting. Do you @cliffniff ?

ChrisLauinger77 commented 9 months ago

I tested a little more. I have configured left click to open track menu and right click to open source menu. left click: Bildschirmfoto vom 2023-10-09 19-23-37

right click: Bildschirmfoto vom 2023-10-09 19-23-45

The sources menu make a bigger button then the track menu ? Seems not right ... Left click / Right click - both are bigger then all other icons. So somehow the theme gets overruled ? @cliffniff Any idea what causes this ?

ChrisLauinger77 commented 9 months ago

But to answer the question if the padding of the icon can be changed. No. it is not only an icon. It also is a panelmenu.button. Which can contain even more panelmenu items inside the widget. This seems to effect the size