search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
236 stars 36 forks source link

Error spam #74

Closed Anuskuss closed 12 months ago

Anuskuss commented 1 year ago

The extension seems unstable because it fills my logs with a bunch of errors:

Feb 21 13:55:41 PC gnome-shell[752]: JS ERROR: TypeError: this._otherProxy is null
                                     get icon@/home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:973:17
                                     _otherPropsChanged@/home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:356:17
Feb 21 13:55:41 PC gnome-shell[752]: JS ERROR: TypeError: this._extension is null
                                     _playerPropsChanged@/home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:327:21
Feb 21 13:55:41 PC gnome-shell[752]: Object St.BoxLayout (0x55d984438890), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: == Stack trace for context 0x55d9815dc170 ==
Feb 21 13:55:41 PC gnome-shell[752]: #0   7ffcc3f3d050 b   resource:///org/gnome/shell/ui/messageList.js:598 (347708b2b600 @ 22)
Feb 21 13:55:41 PC gnome-shell[752]: #1   55d98e29f280 i   resource:///org/gnome/shell/ui/messageList.js:614 (347708b2b790 @ 17)
Feb 21 13:55:41 PC gnome-shell[752]: #2   55d98e29f1e0 i   resource:///org/gnome/shell/ui/messageList.js:610 (347708b2b740 @ 25)
Feb 21 13:55:41 PC gnome-shell[752]: #3   55d98e29f150 i   resource:///org/gnome/shell/ui/mpris.js:268 (347708b34330 @ 58)
Feb 21 13:55:41 PC gnome-shell[752]: #4   7ffcc3f3dbb0 b   resource:///org/gnome/gjs/modules/core/_signals.js:114 (133c2b9a0740 @ 433)
Feb 21 13:55:41 PC gnome-shell[752]: #5   7ffcc3f3dcd0 b   resource:///org/gnome/shell/ui/mpris.js:232 (347708b34150 @ 821)
Feb 21 13:55:41 PC gnome-shell[752]: #6   55d98e29f0b8 i   resource:///org/gnome/shell/ui/mpris.js:184 (347708b340b0 @ 55)
Feb 21 13:55:41 PC gnome-shell[752]: #7   7ffcc3f3e680 b   self-hosted:1115 (133c2b97eec0 @ 463)
Feb 21 13:55:41 PC gnome-shell[752]: #8   55d98e29f018 i   resource:///org/gnome/gjs/modules/core/overrides/Gio.js:259 (133c2b99f1a0 @ 100)
Feb 21 13:55:41 PC gnome-shell[752]: clutter_actor_remove_child: assertion 'child->priv->parent != NULL' failed
Feb 21 13:55:41 PC gnome-shell[752]: Object .Gjs_mediacontrols_cliffniff_github_com_widget_MediaControls (0x55d98344a6e0), has been already disposed — impossible to connect to any signal on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: Object .Gjs_ui_popupMenu_PopupBaseMenuItem (0x55d9925a07c0), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: Object St.Bin (0x55d983b96040), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: Object St.BoxLayout (0x55d984a25760), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: Object .Gjs_ui_boxpointer_BoxPointer (0x55d982cbbef0), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: g_signal_handler_disconnect: assertion 'handler_id > 0' failed
Feb 21 13:55:41 PC gnome-shell[752]: Object .Gjs_ui_boxpointer_BoxPointer (0x55d982cbbef0), has been already disposed — impossible to connect to any signal on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: JS ERROR: TypeError: this._extension is null
                                     _playerPropsChanged@/home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:335:21
Feb 21 13:55:41 PC gnome-shell[752]: Object .Gjs_ui_popupMenu_PopupBaseMenuItem (0x55d9925a07c0), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: == Stack trace for context 0x55d9815dc170 ==
Feb 21 13:55:41 PC gnome-shell[752]: #0   7ffcc3f3dfa0 b   /home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:1078 (285c32bb11a0 @ 104)
Feb 21 13:55:41 PC gnome-shell[752]: #1   7ffcc3f3e870 b   /home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:345 (285c32bacc90 @ 470)
Feb 21 13:55:41 PC gnome-shell[752]: #2   7ffcc3f3e930 b   /home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:338 (285c32bb0600 @ 355)
Feb 21 13:55:41 PC gnome-shell[752]: #3   7ffcc3f3ea30 b   self-hosted:1115 (133c2b97eec0 @ 501)
Feb 21 13:55:41 PC gnome-shell[752]: JS ERROR: TypeError: this._otherProxy is null
                                     get icon@/home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:973:17
                                     updateWidgets@/home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:364:17
                                     _playerPropsChanged@/home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:324:26
Feb 21 13:55:41 PC gnome-shell[752]: Object St.BoxLayout (0x55d98344c890), has been already disposed — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
Feb 21 13:55:41 PC gnome-shell[752]: == Stack trace for context 0x55d9815dc170 ==
Feb 21 13:55:41 PC gnome-shell[752]: #0   7ffcc3f3de60 b   resource:///org/gnome/shell/ui/environment.js:82 (133c2b98c650 @ 20)
Feb 21 13:55:41 PC gnome-shell[752]: #1   7ffcc3f3df70 b   resource:///org/gnome/shell/ui/popupMenu.js:711 (133c2b9e1f60 @ 65)
Feb 21 13:55:41 PC gnome-shell[752]: #2   55d98e29f018 i   /home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:425 (285c32bacd80 @ 69)
Feb 21 13:55:41 PC gnome-shell[752]: #3   7ffcc3f3e930 b   /home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:322 (285c32bb0600 @ 140)
Feb 21 13:55:41 PC gnome-shell[752]: #4   7ffcc3f3ea30 b   self-hosted:1115 (133c2b97eec0 @ 501)

But to be honest I only really noticed that because I was looking through my logs and had to scroll through tens of thousands of error lines (all coming from gnome-shell). I even had to remove a bunch of repeating lines just to be able to post a single second worth of logs so hopefully I didn't remove something important.

ChrisLauinger77 commented 12 months ago

I debugged on the weekend with the version from branch gnome44 and main. I did not see those messages. I fixed some bugs which popped up by sonarlint.

Anuskuss commented 11 months ago

Can't test because it's not compatible with GNOME 45 yet.

ChrisLauinger77 commented 11 months ago

You can use the version from branch gnome44 - this is for gnome43 and gnome44 The main branch is gnome45 - https://github.com/sakithb/media-controls#known-issues You can install it by hand - https://github.com/sakithb/media-controls#other-distributions

See also #94

Anuskuss commented 11 months ago

Got the v26 update today and it seems like there are less error messages now (still plenty but I'm too lazy to match the extensions with their errors).

Could you silence these though:

Okt 15 14:42:23 PC gnome-shell[687]: JS ERROR: Gio.IOErrorEnum: Fehler beim Öffnen der Datei »/home/user/.config/media-controls/cache/aHR0cHM6Ly9pLnNjZG4uY28vaW1hZ2UvYWI2NzYxNmQwMDAwYjI3Mzg3YjM3M2FjM2QwN>
                                     _getImage@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:816:53
                                     get trackIcon@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:979:22
                                     get menuItem@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:945:21
                                     _addPlayer@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:573:36
                                     async*enable/</<@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:387:56
                                     enable/<@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:395:31
                                     asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
                                     @resource:///org/gnome/shell/ui/init.js:21:20
Okt 15 14:42:23 PC gnome-shell[687]: JS ERROR: Error: Failed to save icon.
                                     _saveImage@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:794:43
                                     async*_init/<@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:82:26
                                     async*_init@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:88:15
                                     ButtonBox@resource:///org/gnome/shell/ui/panelMenu.js:13:1
                                     PanelMenuButton@resource:///org/gnome/shell/ui/panelMenu.js:99:4
                                     Player@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/player.js:41:5
                                     _addPlayer@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:564:39
                                     enable/</<@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:387:56
                                     enable/<@file:///home/user/.local/share/gnome-shell/extensions/mediacontrols@cliffniff.github.com/widget.js:395:31
                                     asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
                                     @resource:///org/gnome/shell/ui/init.js:21:20
ChrisLauinger77 commented 11 months ago

@Anuskuss the ones you reported on 22 Feb in this issue are all fixed - they where unhandled exceptions and not good. The current ones are handled exceptions - not harmful and I also already noticed them - when I have time I will tackle them.