search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
224 stars 33 forks source link

[Feature Request] Toggle instead of open, for "track information menu" #75

Closed HubKing closed 9 months ago

HubKing commented 1 year ago

In settings -> Other, if I assign "open track information menu" to a mouse action, such as left click, and do that action to show the track information and do the action again, it re-opens the track information. I think a more sensible behaviour would be just closing the track information when it is already opened.

That is, I think "Toggle track information menu" makes more sense, because I don't think anyone would want to re-open it when it is already opened.

NaiveInvestigator commented 1 year ago

I agree too, this is expected behaviour.

is there any updates on this FR?

ChrisLauinger77 commented 9 months ago

Currently it does what it says - it opens it. Edit: I configured "left click - open track information menu" "right click - open sources menu" both open when I click (on the player icon) and when I click again (on the player icon) they close

ChrisLauinger77 commented 9 months ago

@cliffniff looks like the settings are named "open" but they actually toggle. toggle_menu: _("Open sources menu"), toggle_info: _("Open track information menu"), I change the texts (and translation) today evening.

ChrisLauinger77 commented 9 months ago

Fixed in main and gnome44