search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
224 stars 33 forks source link

Explain: "Options > Blacklist Players" please - also need a "Stop" button #81

Closed rizlaw closed 9 months ago

rizlaw commented 1 year ago

I see no explanation how to use this feature, although it would appear to be self-evident. You enter the player you want to blacklist and hit the "+" sign. The problem is it doesn't work that why from what I can tell.

So how do you blacklist "vlc" and "firefox" from being automatically picked up by this extension and controlled? If this feature is broken it should be fix or removed and at the very least a short explanation on how to use it would be nice.

Also, the extension needs a "stop" button to control those players that still use a "stop" button like Audacious and DeadBeef. "Stop" is important when outputting to ALSA directly.

ChrisLauinger77 commented 9 months ago

The blacklist is fixed with #90 - but this is only for gnome 45. The complete prefs dialog got refactored. Not easy to overtake to gnome 44 and older. I doubt I find time to do it. The stop button would be a new feature.

ChrisLauinger77 commented 9 months ago

I meanwhile also fixed the blacklist in branch gnome44. But its not updated on E.G.O. - @cliffniff do you also plan to upload/release the version from branch gnome44 ? It would give debian (gnome43) and other distros which are not on gnome45 soon also some fixes / translation / new settings dialog. Also the caching which requires soup3 (https://gjs.guide/extensions/upgrading/gnome-shell-43.html#soup3) is changed in this branch (see #85) .

ChrisLauinger77 commented 9 months ago

@cliffniff for the stop button request - I do not think it is really nec. most of the players do not have it. I have the feeling it would result in more issues - what are your thoughts about the stop button ?

sakithb commented 9 months ago

I meanwhile also fixed the blacklist in branch gnome44. But its not updated on E.G.O. - @cliffniff do you also plan to upload/release the version from branch gnome44 ? It would give debian (gnome43) and other distros which are not on gnome45 soon also some fixes / translation / new settings dialog. Also the caching which requires soup3 (https://gjs.guide/extensions/upgrading/gnome-shell-43.html#soup3) is changed in this branch (see #85) .

Yeah, I will publish a release for gnome 44. The 45 release is still being reviewed.

sakithb commented 9 months ago

@cliffniff for the stop button request - I do not think it is really nec. most of the players to not have it. I have the feeling it would result in more issues - what are your thoughts about the stop button ?

I agree it is not necessary, if more users request this feature we can add it as opt-in, what do you think?

ChrisLauinger77 commented 9 months ago

I think it will cause more harm then it would help. Closing it

ChrisLauinger77 commented 9 months ago

@cliffniff I found a list of all unreviewed extensions: https://extensions.gnome.org/review/