search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
228 stars 33 forks source link

mouse action doesn't work when player icon is hidden #9

Closed carlwgeorge closed 2 years ago

carlwgeorge commented 2 years ago

If you set hide-player-icon to true and mouse-action-left to toggle_play, clicking on the title does nothing. If you set hide-player-icon to false then clicking on the title does the expected action. This is reproducible on both GNOME 3.38.6 (Fedora 33) and GNOME 40.4 (Fedora 34).

sakithb commented 2 years ago

I've tested it and you are correct, mouse actions don't work if any of the elements are hidden. I'll try to fix this issue as soon as possible. I will notify once the fix has been issued. Thanks for reporting this issue!

sakithb commented 2 years ago

It was an easy fix. The fix will be available in the next release, until then you can clone the repo and install from source. Instructions are available here. I won't be closing this issue until the next release. Again thanks for reporting the issue!

carlwgeorge commented 2 years ago

Sure thing, thanks for the quick fix.

arejula27 commented 2 years ago

The real bug is not that it doesn't work, it is that the left button has the action of the right button

sakithb commented 2 years ago

The real bug is not that it doesn't work, it is that the left button has the action of the right button

Fixed it in the latest commit.

sakithb commented 2 years ago

Fixed it in the latest release!