search

sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
236 stars 36 forks source link

port to ESM modules (gnome 45) #90

Closed ChrisLauinger77 closed 1 year ago

ChrisLauinger77 commented 1 year ago

gnome 45 - ESM modules. it will only work on gnome 45 and newer. https://gjs.guide/extensions/upgrading/gnome-shell-45.html#shell-version When the extension only supports GNOME 44 and later the compiled schemas should not be included any more.

extension is ported for now and loads prefs is WIP

ChrisLauinger77 commented 1 year ago

@cliffniff I would be interested to continue development. Wanna add me as maintainer ? Would you still upload to https://extensions.gnome.org/extension/4470/media-controls/ ? Or should this be done also by me ?

ChrisLauinger77 commented 1 year ago

some preview - prefs dialog - work in progress page 2-4 or not started yet

Bildschirmfoto vom 2023-08-24 18-33-37

ChrisLauinger77 commented 1 year ago

Page2 Bildschirmfoto vom 2023-08-25 15-13-06 Page3 Bildschirmfoto vom 2023-08-25 15-13-17

ChrisLauinger77 commented 1 year ago

Page 4 Bildschirmfoto vom 2023-08-25 15-59-28

sakithb commented 1 year ago

@ChrisLauinger77 sorry for not replying earlier. I can add you as a maintainer. I have some time in my hands in the coming months so I will be able to contribute as well.

ChrisLauinger77 commented 1 year ago

@cliffniff OK cool thx.

ChrisLauinger77 commented 1 year ago

@cliffniff will you upload it to https://extensions.gnome.org/extension/4470/media-controls/ ? current version is only gnome 44

sakithb commented 12 months ago

I will upload it. What system did you test it on. I tried installing it on fedora 39 beta, could not get it to work.

ChrisLauinger77 commented 12 months ago

I have it running in a VM (gnome-boxes) with GNOME OS nightly. My main machine is on debian testing (gnome 44)

ChrisLauinger77 commented 12 months ago

@cliffniff If there is any finding from the review EGO - please tell me. Maybe create an issue which I can work on ?

sakithb commented 12 months ago

@ChrisLauinger77 The review is still pending. I will let you know when it's approved or rejected

ChrisLauinger77 commented 12 months ago

@cliffniff Wow - usually they are really really fast. Anyways. I did some work in gnome44 and main. Fixed some bugs and splitted the prefs page4 into 2. Gnome 44 branch now also uses the new Adw.Preferences page

sakithb commented 12 months ago

@ChrisLauinger77 That's great. I can also start contributing from tomorrow onwards, since I have some spare time. It's been two days since I submitted for review, I guess they have a lot of extensions to review since Gnome 45 release.

ChrisLauinger77 commented 12 months ago

@cliffniff Might be they are busy. I did the 4 I maintain during the beta. But a lot of people waited until release ...