sakithb / media-controls

A media indicator for the Gnome shell.
MIT License
224 stars 33 forks source link

Added seek slider #96

Closed sakithb closed 8 months ago

sakithb commented 8 months ago

Fix for #33

sakithb commented 8 months ago

Should be ported for gnome 45/v26 *sorry i mean v28

ChrisLauinger77 commented 8 months ago

main would be v28 next release - I can do the porting / testing on gnome OS

sakithb commented 8 months ago

main would be v28 next release - I can do the porting / testing on gnome OS

For gnome 44 it's v27 right

ChrisLauinger77 commented 8 months ago

yes gnome44 branch has 27 in metadata and is not released yet

ChrisLauinger77 commented 8 months ago

netflix netflix youtube youtube spotify spotify

only spotify looks OK - and I do not see the slider only the time counts.

sakithb commented 8 months ago

image image Weird. it looks fine for me. What theme are you using?

ChrisLauinger77 commented 8 months ago

Custom accent colors theme - but it looks the same when I use the default one

And in log there is now:

{ "PlaybackStatus": "Playing" } { "Metadata": { "mpris:trackid": "/com/spotify/track/6dkffLWo31KnXmwCLsgA2K", "mpris:length": 130226000, "mpris:artUrl": "https://i.scdn.co/image/ab67616d0000b273c4e6adea69105e6b6e214b96", "xesam:album": "TEC", "xesam:albumArtist": [ "Lil Tecca" ], "xesam:artist": [ "Lil Tecca" ], "xesam:autoRating": 0.74, "xesam:discNumber": 1, "xesam:title": "Gist", "xesam:trackNumber": 3, "xesam:url": "https://open.spotify.com/track/6dkffLWo31KnXmwCLsgA2K" } }

should not be there right ?

sakithb commented 8 months ago

judging from the left padding in the popup, you seem to be not using the code in the dev-legacy branch. I fixed the padding issues as well

ChrisLauinger77 commented 8 months ago

yes I use the seek-ft - do not see the dev-legacy ?!

sakithb commented 8 months ago

yes I use the seek-ft - do not see the dev-legacy ?!

seek-ft was merged with dev-legacy, can you try pulling again

ChrisLauinger77 commented 8 months ago

yes - needed to fetch origin . now I test again

ChrisLauinger77 commented 8 months ago

Spotify looks better now Bildschirmfoto vom 2023-10-17 20-26-57

But youtube and netflix not Bildschirmfoto vom 2023-10-17 20-27-42

Bildschirmfoto vom 2023-10-17 20-28-06

ChrisLauinger77 commented 8 months ago

Also Ignoring length property that isn't a number at line 21, col 17 Ignoring length property that isn't a number at line 22, col 18 Ignoring length property that isn't a number at line 1, col 13 Ignoring length property that isn't a number at line 1, col 32 Ignoring length property that isn't a number at line 21, col 17 Ignoring length property that isn't a number at line 22, col 18

this log messages are back which I fixed already - they come from margin: 0px auto; the auto is not supported I believe

sakithb commented 8 months ago

It's not working properly on firefox, only chromium based browsers. Ill look into it more. Regarding the logs did you fix them in the gnome 44 branch as well?

ChrisLauinger77 commented 8 months ago

I think I need to rebase gnome44 onto dev-legacy.

ChrisLauinger77 commented 8 months ago

It's not working properly on firefox, only chromium based browsers. Ill look into it more. Regarding the logs did you fix them in the gnome 44 branch as well?

yes but after you branched - I rebase and push - just a sec

ChrisLauinger77 commented 8 months ago

After rebase its fine and also the fixes from gnome44 are in dev-legacy. logs looks good now. Wanna investigate and fix firefox before the PR is done ?

sakithb commented 8 months ago

After rebase its fine and also the fixes from gnome44 are in dev-legacy. logs looks good now. Wanna investigate and fix firefox before the PR is done ?

Thanks! I am working on fixing firefox. Actually it cannot be fixed because firefox does not expose the position information for any media playing, I guess we'll just have to hide the slider and the timestamps?

ChrisLauinger77 commented 8 months ago

confirm chromium also works for me Bildschirmfoto vom 2023-10-17 20-44-05

ChrisLauinger77 commented 8 months ago

Yes just hide it when its not supported - spares us new issues :)

sakithb commented 8 months ago

I agree

ChrisLauinger77 commented 8 months ago

Good job BTW - I like it very much

sakithb commented 8 months ago

Thanks!

Good job BTW - I like it very much

I pushed the changes

ChrisLauinger77 commented 8 months ago

Testing them - give me 5 minutes

ChrisLauinger77 commented 8 months ago

Branch merged and cleaned - I will port the changes to main