search

sakrejda / protostan

Thin protobuf interface wrapper for Stan
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Replace 'stanc' with 'compile' #18

Closed ariddell closed 8 years ago

ariddell commented 8 years ago

'stanc' is a cmdstan-ism. Using compile everywhere (incl. filenames) is clearer.

ariddell commented 8 years ago

This is a bit more involved than I thought. We need to compile protostan's tests without relying on Stan's makefile. In principle people using protostan will be working with a different Stan tree and will not have libstan.a on hand (I think this is right).

sakrejda commented 8 years ago

Could you explain why this is tied up with Stan's makefile? I don't see the connection to not using "stanc" as a name.

ariddell commented 8 years ago

There's a rule in the Makefile which uses libstanc.a -- I'm pretty sure this is an artifact which is there for cmdstan from the days when cmdstan was part of the stan repo. I may be wrong about this.

sakrejda commented 8 years ago

I thought PyStan would also need to do the compilation required to make something like libstanc.a, no? Do you really recompile everything for every model?

ariddell commented 8 years ago

PyStan compiles a hybrid Python/C++ thing for compilation separately. When models are compiled they don't need to use the stan/lang stuff.

For testing I think it makes sense to leave libstanc.a the way it is. But I do think it's a good idea to replace 'stanc' with 'compile' elsewhere. That's the function signature after all. Without knowledge of cmdstan I think 'stanc' doesn't have a clear reference.

On 01/04, Krzysztof Sakrejda wrote:

I thought PyStan would also need to do the compilation required to make something like libstanc.a, no? Do you really recompile everything for every model?

Reply to this email directly or view it on GitHub: https://github.com/sakrejda/protostan/issues/18#issuecomment-168861946

sakrejda commented 8 years ago

Ok, works for me. I can take care of it, I think there's some proto file/c++ namespace issue involved. On Jan 5, 2016 9:04 AM, "Allen Riddell" notifications@github.com wrote:

PyStan compiles a hybrid Python/C++ thing for compilation separately. When models are compiled they don't need to use the stan/lang stuff.

For testing I think it makes sense to leave libstanc.a the way it is. But I do think it's a good idea to replace 'stanc' with 'compile' elsewhere. That's the function signature after all. Without knowledge of cmdstan I think 'stanc' doesn't have a clear reference.

On 01/04, Krzysztof Sakrejda wrote:

I thought PyStan would also need to do the compilation required to make something like libstanc.a, no? Do you really recompile everything for every model?

Reply to this email directly or view it on GitHub: https://github.com/sakrejda/protostan/issues/18#issuecomment-168861946

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/issues/18#issuecomment-169009480.

ariddell commented 8 years ago

I've got a PR ready, let me send that.

sakrejda commented 8 years ago

Ok On Jan 5, 2016 9:39 AM, "Allen Riddell" notifications@github.com wrote:

I've got a PR ready, let me send that.

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/issues/18#issuecomment-169018619.