search

sakrejda / protostan

Thin protobuf interface wrapper for Stan
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Remove model_file_name from StanCompileRequest #19

Closed ariddell closed 8 years ago

ariddell commented 8 years ago

model_file_name is not used in Stan. It's an artifact of old code.

See Stan stan-dev/stan#1752

Closes #16 and #13.

sakrejda commented 8 years ago

Looks good, I'll merge when the Stan pull request goes through. I think that makes sense.

syclik commented 8 years ago

Anyone else see the branch conflicts?

ariddell commented 8 years ago

I think I messed things up. One second...

ariddell commented 8 years ago

Got it. Conflicts resolved.

syclik commented 8 years ago

Can you push to both the branch on your fork and to stan-dev/stan?

For future reference, it's much easier if the PR comes from within the stan-dev/stan repo for this reason.

On Tue, Jan 26, 2016 at 4:12 PM, Allen Riddell notifications@github.com wrote:

Got it. Conflicts resolved.

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/pull/19#issuecomment-175232061.

ariddell commented 8 years ago

You're talking about stan-dev/stan#1752, right? This is a different PR (on protostan)