sakrejda / protostan

Thin protobuf interface wrapper for Stan
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Include path for generated (from .proto) cpp files is wrong #25

Closed ariddell closed 8 years ago

ariddell commented 8 years ago

The way the makefile works right now we get a stanc.pb.cc which has this line ``

include "proto/stanc.pb.h"

but our source directory issrc/so this needs to be

include "stan/proto/stanc.pb.h"

``

ariddell commented 8 years ago

It seems like there's a convention about where to put proto files that we're missing.

ariddell commented 8 years ago

Ok, I found an answer here: https://stackoverflow.com/questions/18735609/the-path-in-protobuf

If we want to keep the .proto files in a separate directory then the directory structure inside this directory has to mirror the directory structure inside the C++ source tree.