search

sakrejda / protostan

Thin protobuf interface wrapper for Stan
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Move .proto files into source tree #26

Closed ariddell closed 8 years ago

ariddell commented 8 years ago

If we want the generated C++ from the .proto files to live in stan/proto (which would mirror the stan directory structure) then it looks like the .proto files need to live in a directory structure that mirrors the source structure. It seems like putting the .proto files in the place where the .pb.cc and .pb.h files will be generated solves this problem.

Closes #25

ariddell commented 8 years ago

@sakrejda I'm going to merge this so I can build pystan-protostan. This really is a bugfix, I made a mistake of including "src/stan" (should be just "src") in the include paths in the Makefile so we never caught this problem.

sakrejda commented 8 years ago

Sounds good, I think that include was a kludge I added so things would build where you put them... K On Jan 8, 2016 8:07 AM, "Allen Riddell" notifications@github.com wrote:

Merged #26 https://github.com/sakrejda/protostan/pull/26.

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/pull/26#event-509385214.

ariddell commented 8 years ago

Honestly I don't know where it's best to put the .proto files. It would be great to find a small mature C++ project that's vaguely like Stan that uses proto files heavily.

On 01/08, Krzysztof Sakrejda wrote:

Sounds good, I think that include was a kludge I added so things would build where you put them... K On Jan 8, 2016 8:07 AM, "Allen Riddell" notifications@github.com wrote:

Merged #26 https://github.com/sakrejda/protostan/pull/26.

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/pull/26#event-509385214.

Reply to this email directly or view it on GitHub: https://github.com/sakrejda/protostan/pull/26#issuecomment-170007859