search

sakrejda / protostan

Thin protobuf interface wrapper for Stan
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Feature/proto output messages #34

Closed sakrejda closed 8 years ago

sakrejda commented 8 years ago

Makes messages to match the writer output types. Adds these messages to the union type. The actual writer code will be responsible for: 1) Constructing the union message, 2) packing the info in, and 3) sending it or writing it to file. Seems like there's room to make allow for repeated output messages but that will inevitably bump into size limits again.

The best solution would be to use the "bytes" message type for messages that can get big (mostly the parameter vector) and let the writer be responsible for chunking. Then interfaces would be responsible for chunking too but at least they wouldn't be counting messages and trying to reconstruct them from there.

ariddell commented 8 years ago

Ignore the previous message. I'll keep looking to see why the build is failing.

sakrejda commented 8 years ago

I see this:

make: *\ No rule to make target proto/compile.proto', needed bysrc/stan/proto/compile.pb.cc'. Stop.

I think that dependency is a mistake in the makefile---it was only working before because that file was present in the tree (in the wrong place). I fixed it locally and waiting for test to pass before updating this.

sakrejda commented 8 years ago

Also updated tests. Not sure how those file_name bits were still in the tests (and passing) but I guess it was that we had two .proto file copies hanging around.