Closed sakrejda closed 8 years ago
I don't know the C++ convention here. Does one try to keep an external package in its own namespace? For example, what if by accident we end up clobbering a function name (say, 'compile') in stan::lang with the protostan version?
That should only be an issue for callbacks in the scheme outlined above and there... I don't know. At least callbacks are pretty job-specific and tend to have less common names (and more specialized purposes) so I don't see this being a big issue.
Anyway, this all sounds good.
Looks like:
Looks like we are exposing three types of things: 1) messages; 2) thin wrappers; and 3) callbacks. So generalizing to a namespace policy:
@ariddell Feel free to comment, close if you agree and I'll write it up as a Wiki thing and/or add to README.md