search

sakrejda / protostan

Thin protobuf interface wrapper for Stan
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Enumerate .proto files to be transplied #48

Open ariddell opened 8 years ago

ariddell commented 8 years ago

protoc now needs to be findable in the current PATH.

If protoc is not on the current PATH one will need to do something like

PROTOC=./lib/protobuf/src/protoc make test

(this is part of the Makefile cleanup)

sakrejda commented 8 years ago

I don't know if protoc with proton support is standard every/anywhere (e.g.-Ubuntu)---I think not, so this will break everything. :/

On Tue, Mar 8, 2016 at 2:25 PM, Allen Riddell notifications@github.com wrote:

protoc now needs to be findable in the current PATH.

If protoc is not on the current PATH one will need to do something like

PROTOC=./lib/protobuf/src/protoc make test

(this is part of the Makefile cleanup)

You can view, comment on, or merge this pull request online at:

https://github.com/sakrejda/protostan/pull/48 Commit Summary

  • Enumerate .proto files to be transplied

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/pull/48.

ariddell commented 8 years ago

I just followed Google's protobuf install instructions. I think we should at minimum figure out a way to support the official install instructions.

ariddell commented 8 years ago

I'll fix the failing build in a second.

ariddell commented 8 years ago

What's proton support?

sakrejda commented 8 years ago

ha, proto3

On Tue, Mar 8, 2016 at 2:46 PM, Allen Riddell notifications@github.com wrote:

What's proton support?

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/pull/48#issuecomment-193938903.

sakrejda commented 8 years ago

I hate spellcheck on this mac...

On Tue, Mar 8, 2016 at 2:46 PM, Allen Riddell notifications@github.com wrote:

What's proton support?

— Reply to this email directly or view it on GitHub https://github.com/sakrejda/protostan/pull/48#issuecomment-193938903.

ariddell commented 8 years ago

I'm thinking about this repo as providing a library, like boost or stan-math. PyStan and cmdstan-protostan, for example, would ship the generated .pb.cc files with releases, so nobody would need to worry about having protoc. Getting proto3 support is a challenge but in a year I think there's going to be no problem. We can talk more on Friday about this as well.

ariddell commented 8 years ago

OK. It's passing. I have another PR that builds on this one but I thought it might be easiest to break them up.